Skip to content

Conversation

@zulquer
Copy link
Collaborator

@zulquer zulquer commented May 6, 2025

This pull request includes updates to type annotations and configuration files to improve code clarity and maintainability. The most important changes involve refining type hints in constructors and updating the pyproject.toml file to adjust linting rules.

Type annotation improvements:

Configuration updates:

  • pyproject.toml: Removed the ANN003 rule from the ignore list, ensuring stricter adherence to type annotation guidelines.

@zulquer zulquer requested a review from Copilot May 6, 2025 11:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves type annotations for better code clarity and maintainability while updating linting configuration to enforce stricter rules. The key changes include:

  • Refining type annotations in the init methods of the Listing and CustomApiResponse classes.
  • Updating the pyproject.toml file to remove the ANN003 ignore rule so that annotation errors are caught.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/multisafepay/api/base/response/custom_api_response.py Added explicit dict[str, Any] type for **kwargs in the init method to improve clarity.
src/multisafepay/api/base/listings/listing.py Refined type annotations in the init method, using list[Any] and dict[str, Any] for improved precision.
pyproject.toml Removed the ANN003 rule from the ignore list to enforce stricter type annotation guidelines.

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (bf36592) to head (76bfd88).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         106      106           
  Lines        2305     2305           
=======================================
  Hits         2092     2092           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zulquer zulquer merged commit 93bacee into master May 6, 2025
7 checks passed
@zulquer zulquer deleted the PTHMINT-41 branch May 6, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants