Skip to content

Conversation

@zulquer
Copy link
Collaborator

@zulquer zulquer commented Jul 17, 2025

This pull request removes several fields and their associated methods from the Delivery class in the src/multisafepay/api/shared/delivery.py file, along with corresponding test cases in the tests/multisafepay/unit/api/shared/test_unit_delivery.py file. The removed fields include street_name, street_name_additional, house_number_suffix, and country_name.

Changes to the Delivery class:

  • Removed the fields street_name, street_name_additional, house_number_suffix, and country_name from the Delivery class definition. [1] [2]
  • Deleted methods for adding these fields (add_street_name, add_street_name_additional, add_house_number_suffix, and add_country_name).

Changes to test cases:

  • Updated the test_initializes_with_valid_values and test_initializes_with_default_values tests to remove assertions related to the deleted fields. [1] [2] [3]
  • Removed specific test cases for the deleted fields, such as test_adds_street_name, test_adds_street_name_additional, and test_adds_house_number_suffix.
  • Updated the test_creates_from_dict_with_all_fields and test_creates_from_empty_dict tests to remove references to the deleted fields. [1] [2] [3]

@zulquer zulquer requested a review from danielcivit July 17, 2025 12:38
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (446bd2c) to head (c7ebf0e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   90.40%   90.42%   +0.02%     
==========================================
  Files         106      106              
  Lines        2323     2307      -16     
==========================================
- Hits         2100     2086      -14     
+ Misses        223      221       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielcivit danielcivit merged commit 781818c into master Jul 17, 2025
6 checks passed
@danielcivit danielcivit deleted the PTHMINT-75 branch July 17, 2025 12:52
@danielcivit danielcivit restored the PTHMINT-75 branch July 17, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants