PTHMINT-51: Fix ruff BLE001 #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling across multiple manager classes in the codebase by refining how data validation exceptions are caught and reported. Specifically, it replaces broad exception handling with targeted handling of
pydantic.ValidationErrorwhen parsing or constructing data models from API responses. This change ensures that only relevant validation errors are caught, leading to clearer, more accurate warning messages and improved maintainability.Error handling improvements:
Replaced generic
Exceptionhandling with explicitValidationErrorhandling frompydanticin all manager classes when parsing API response data into models (e.g.,Order,Gateway,Issuer,Token, etc.), ensuring only schema validation errors are caught and reported. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Added
from pydantic import ValidationErrorimports to all relevant manager files to support the new error handling approach. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Code cleanup:
Configuration update:
pyproject.tomlto remove"BLE001"from the ignore list, possibly to enable linting for a specific code style rule.