Skip to content

PTHMINT-64: Remove sdk version #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcivit merged 2 commits into from
Apr 23, 2025
Merged

PTHMINT-64: Remove sdk version #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf1bf6
PTHMINT-64: Remove sdk version
zulquer Apr 23, 2025
99bdd5f
PTHMINT-64: Remove the print statement used for debugging in the test…
zulquer Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 16 additions & 62 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ homepage = "https://multisafepay.com"
[tool.poetry.dependencies]
python = ">=3.8,<3.14"
requests = "^2.32.3"
toml = "^0.10.2"
pydantic = "^1.10.0"
python-dotenv = "^1.0.1"

Expand Down
22 changes: 0 additions & 22 deletions src/multisafepay/api/paths/orders/request/components/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from typing import Optional

from multisafepay.model.request_model import RequestModel
from multisafepay.util.version import Version


class Plugin(RequestModel):
Expand All @@ -18,7 +17,6 @@ class Plugin(RequestModel):

Attributes
----------
sdk_version (Optional[str]): The version of the SDK.
plugin_version (Optional[str]): The version of the plugin.
shop (Optional[str]): The name of the shop.
shop_version (Optional[str]): The version of the shop.
Expand All @@ -27,32 +25,12 @@ class Plugin(RequestModel):

"""

sdk_version: Optional[str] = Version.detect_sdk_version()
plugin_version: Optional[str]
shop: Optional[str]
shop_version: Optional[str]
partner: Optional[str]
shop_root_url: Optional[str]

def add_sdk_version(
self,
sdk_version: Optional[str],
) -> "Plugin":
"""
Adds the SDK version to the Plugin object.

Parameters
----------
sdk_version (Optional[str]): The version of the SDK.

Returns
-------
Plugin: The updated Plugin object.

"""
self.sdk_version = sdk_version
return self

def add_plugin_version(
self,
plugin_version: Optional[str],
Expand Down
Loading