Recursive sub-sub-sections components #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- writing of imports + component code (write python file) - component - fct map for generation - building list of components
- first section is home section recording it's compents - needs to be treated separately
- add overview page for each section showing components in main section folder
- Section could be used everywhere, Subsection is not really necessary. If a Section has subsections, the logic changes. Else nothing changes.
- set based on report type, and this is set on init - avoid to pass on variable to all functions.
- same as for streamlit_report to prepare refactoring of components parsing.
- very similar to _combine_components in streamlit_report - imports has to be a list of list -> figure this out - added debug message for skipping components in static reports-> should maybe be a warining?
- default still on subsection level - could consider to make subsubsections instead of adding components to subsection
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new command‐line argument and UI control for setting a maximum recursive depth when scanning directories for report components. Key changes include adding a --max_depth argument in the CLI, propagating the max_depth value through report generation (including updates to ConfigManager and report_generator), and adding a slider in the GUI to allow users to adjust this value.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vuegen/utils/init.py | Added a new CLI argument for maximum recursion depth. |
| src/vuegen/streamlit_reportview.py | Minor removal of redundant variable assignments for section names. |
| src/vuegen/report_generator.py | Propagated max_depth into report generation and config manager usage. |
| src/vuegen/config_manager.py | Updated initialization and directory parsing to respect max_depth. |
| src/vuegen/main.py, gui/app.py | Updated main function and GUI to pass and enforce max_depth values. |
sayalaruano
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats: