-
Notifications
You must be signed in to change notification settings - Fork 0
Entrypoint #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entrypoint #38
Conversation
either have a default for report type, or not. But None is not a valid default.
|
I added integration tests for all scripts. I still need to allow the report to be called as https://github.com/Multiomics-Analytics-Group/vuegen/actions/runs/12429117006/job/34701961965 ERROR: Validation of YAML front matter failed.
ERROR: In file quarto_report/quarto_report.qmd
(line 9, columns 5--19) Field "format" has value kernel: python3, which must instead be no possible value
8: jupyter:
9: kernel: python3
~~~~~~~~~~~~~~~
10: ---
ERROR: Render failed due to invalid YAML.Is that okay? Do you want to do something about it? If it is an actual error, I would argue that the execution stops and return a non-zero exit code. |
|
@sayalaruano I think its's ready also without the jupyter error. If I read it correctly it's mainly about the default kernel. maybe it |
|
Hey @enryH! I took a look at the jupyter error, and got the same result in my local env. It seems that another way to create the ipynb file from the qmd file is with the command:
https://quarto.org/docs/tools/jupyter-lab.html I can add this change in the quarto_reportview.py file. Do you think this will be better, or should we just keep as it is? |
|
Does the error have an impact or not? I think we can discuss this once we tested it a bit... But if you know what should be the result, and the changed command does it, go ahead:) |
…o convert command
|
|
||
| ```bash | ||
| python vuegen/main.py --config docs/example_data/MicW2Graph/report_config_micw2graph.yaml --report_type streamlit | ||
| cd docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Why is it necessary to change the directory to docs? In my local environment, it's working when I execute the program from the base folder, not from docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to check when I am back, but you could double check in a clean environment within a code space on that branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will check that out. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested in a code space clean environment and it works without changing the directory to docs. Also, I identified some errors with the docx, odt, and pdf formats when converting a df into an image:
OSError: Chrome executable not able to be found on your machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well. Then this is another requirement. So which tool relies on chronium? Probably something for the interactive dataframes (itables)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cd docs:
- I wanted to check that the import is not local.
vuegenis on the main folder, not jet using thesrclayout, i.e. moving the packages into a separatesrcfolder. - For building the website I will need to have the example report relative to the
docs/conf.pyfile. In the end someone who uses the report generator will have only a folder resembling the docs.
In short: yes we can remove the docs, but let's to it in a separate PR where we change the layout of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that dataframe_image is the one that relies on chromium.
It's ok to remove the cd docs in an independent PR. And should we merge the current PR into the meain with the cd docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do it now.
…pdate gitignore and class diagram
Make report generator executable from anywhere.