Refactor: reduce code complexity per audit findings - #28
Merged
Conversation
- Unify processMessage/rebuildFromHistory via shared applyMessageMut() - Extract usePromptState hook (7 useState → 1 hook) from useChatSocket - Extract RepoSection component (331 lines) from LeftSidebar - Extract 8 WorkflowsView sub-components into src/components/workflows/ - Extract useSessionOrchestration hook (153 lines) from App.tsx - Extract WebhookHandlerBase generic class shared by webhook + stepflow - Split SessionManager: extract ApprovalManager, SessionNaming, SessionPersistence Net: -1200 lines from existing files, zero behavior changes. All 855 tests pass, build clean, zero lint errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Further reduces SessionManager from 1,640 to 1,249 lines by fully delegating approval, naming, and persistence logic to the extracted ApprovalManager, SessionNaming, and SessionPersistence classes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The gh repo list command returns repos sorted by most recently pushed, causing the sidebar order to shuffle unpredictably. Sort by name instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processMessage/rebuildFromHistoryswitch logic via sharedapplyMessageMut()in useChatSocketusePromptStatehook (7 useState calls → 1 hook) anduseSessionOrchestrationhook from App.tsxRepoSectioncomponent (331 lines) from LeftSidebar into its own fileWorkflowsView(758→244 lines) into 8 sub-components undersrc/components/workflows/WebhookHandlerBasegeneric base class shared by webhook and stepflow handlersSessionManagergod object: extractedApprovalManager,SessionNaming,SessionPersistenceNet result: -1,200 lines from existing files, 15 new focused modules. Zero behavior changes.
Test plan
🤖 Generated with Claude Code