Merged
Conversation
Address all findings from the 2026-03-09 security audit: High: Fix SSRF deny-by-default in Stepflow callbacks, move auth token off WebSocket URL to post-connect message, replace master auth token with HMAC-derived session-scoped tokens for child processes. Medium: Enforce CORS_ORIGIN in production, add per-IP WebSocket rate limiting, set 0600 on persisted state files, add secret redaction to command logging, replace execSync with execFileSync. Low: Add CSP/HSTS/Permissions-Policy headers, wrap workspace setup in try/finally for cleanup, tighten clone endpoint name validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowedCallbackHostsguard to deny-by-default when unconfiguredauthmessage handshake instead of query string to prevent log/referrer exposureCORS_ORIGINin production (NODE_ENV=productionexits if unset)0600permissions on all persisted state files (sessions, approvals, workflow config)execSync('claude --version')withexecFileSyncto avoid shell invocationContent-Security-Policy,Permissions-Policy,Strict-Transport-Security(production), changeX-Frame-OptionstoDENYcreateWorkspacein try/finally to clean up partial workspaces on failure.(blocks.git,..)Addresses all findings from the 2026-03-09 security audit.
Test plan
STEPFLOW_CALLBACK_HOSTSis unset🤖 Generated with Claude Code