Refactor to remove need for ParsedDestination and add destination tests #3130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Contract | ||
| public interface Destination<T extends DestinationInstance> { | ||
| public interface Destination<D extends Destination<D, T>, T extends DestinationInstance<T, D>> { |
Member
There was a problem hiding this comment.
Not crazy about the recursive generics here. Can you summarize what this is doing? Having some difficulty following.
Member
Author
There was a problem hiding this comment.
Its just each Destination maps a one DestinationInstance
Member
Author
There was a problem hiding this comment.
This is so that ExactDestination.parseDestination() can only return ExactDestinationInstance, then ExactDestinationInstance.getDestination() can only return ExactDestination.
Kinda like a 1 to 1 map thing, where you cant just allow ExactDestination to return any type of DestinationInstance and ExactDestinationInstance cannot be created by any type of Destination only ExactDestination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParsedDestination was just like a proxy for DestinationInstance, i realised it was a dumb way of implementing, so i removed it. Need this changes to update multiverse-portals to work with mv5 core.