Skip to content

Maintain spawn category config order between config saves #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwoo1110 merged 1 commit into from
Aug 27, 2025
Merged

Maintain spawn category config order between config saves #3326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/mvplugins/multiverse/core/world/entity/EntitySpawnConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.mvplugins.multiverse.core.world.entity;

import com.dumptruckman.minecraft.util.Logging;
import org.bukkit.World;
import org.bukkit.configuration.ConfigurationSection;
import org.bukkit.configuration.MemoryConfiguration;
import org.bukkit.entity.Entity;
Expand All @@ -10,7 +9,7 @@
import org.mvplugins.multiverse.core.utils.StringFormatter;
import org.mvplugins.multiverse.core.world.MultiverseWorld;

import java.util.HashMap;
import java.util.LinkedHashMap;

Check warning on line 12 in src/main/java/org/mvplugins/multiverse/core/world/entity/EntitySpawnConfig.java

View workflow job for this annotation

GitHub Actions / checkstyle / checkstyle 

[checkstyle] reported by reviewdog 🐶
Wrong order for 'java.util.LinkedHashMap' import.

Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/entity/EntitySpawnConfig.java:12:1: warning: Wrong order for 'java.util.LinkedHashMap' import. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
import java.util.Map;

public final class EntitySpawnConfig {
Expand Down Expand Up @@ -53,7 +52,7 @@

@ApiStatus.Internal
public static EntitySpawnConfig fromSection(ConfigurationSection section) {
Map<SpawnCategory, SpawnCategoryConfig> spawnCategoriesConfig = new HashMap<>();
Map<SpawnCategory, SpawnCategoryConfig> spawnCategoriesConfig = new LinkedHashMap<>();
section.getValues(false).forEach((key, value) -> {
if (!(value instanceof ConfigurationSection sectionPart)) {
Logging.warning("Invalid spawn category config for " + key + ": " + value);
Expand Down