-
Notifications
You must be signed in to change notification settings - Fork 3
Add new instructions #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for two new quantum instructions (swap and reset) to enable compatibility with new backends. The version is bumped from 0.2.0 to 0.2.1 to reflect this enhancement.
- Adds
ResetandSwapGateimports from Qiskit - Implements handler functions for both new instructions following existing patterns
- Updates the instruction map to include the new instructions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Increments version from 0.2.0 to 0.2.1 for the patch release |
| mqss/qiskit_adapter/mqss_resources.py | Adds Reset and SwapGate imports, implements their handler functions, and registers them in the instruction_map |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bmete7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning for reset instruction no longer exists, and jobs succeed without any issues. However:
test/test_backend.py::TestMQSSQiskitBackend::test_run_job_qasm3 Warning: Instruction 'if_else' not found in the instruction_map.
Should we add this as well?
I could not find |
|
I think there are two options:
or Here are more detailed explanations on here: I think overall, the instruction is called if_test. |
|
You might want to look at the IfElseOp docs as well: https://quantum.cloud.ibm.com/docs/en/api/qiskit/qiskit.circuit.IfElseOp |
|
Thank you @burgholzer and @Bmete7 for the links. I will add it and see if it works. |
Add the following new instruction to support new backends