Skip to content

Fix device template test #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
burgholzer merged 3 commits into from
Sep 17, 2025
Merged

Fix device template test #225

burgholzer merged 3 commits into from
Sep 17, 2025

Conversation

@ystade
Copy link
Collaborator

@ystade ystade commented Sep 15, 2025 •
edited
Loading

Description

Fixes #170

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or
    removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@ystade ystade added this to the v1.2.0 milestone Sep 15, 2025
@ystade ystade self-assigned this Sep 15, 2025
@ystade ystade added the fix Fixes something that isn't working label Sep 15, 2025
burgholzer
burgholzer approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ystade CI is running again now. For some reason, the CI workflow was disabled 🤷🏼
However, it is failing with a similar error as observed in #154.
So this is definitely a systematic issue.
I will, nevertheless, merge this PR as is for now.

@burgholzer burgholzer merged commit 94b5175 into Munich-Quantum-Software-Stack:develop Sep 17, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@ystade ystade

Labels

fix Fixes something that isn't working

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

🐛 Erroneous test in template

2 participants

@ystade @burgholzer