Make CommitList display "Working tree clean"#708
Draft
jensenr30 wants to merge 1 commit intoMurmele:masterfrom
Draft
Make CommitList display "Working tree clean"#708jensenr30 wants to merge 1 commit intoMurmele:masterfrom
jensenr30 wants to merge 1 commit intoMurmele:masterfrom
Conversation
Owner
|
Thanks for the changes. Is this ready? |
Contributor
Author
jensenr30
force-pushed
the
working-tree-clean
branch
from
0d30464 to
13544c2
Compare
Contributor
Author
jensenr30
force-pushed
the
working-tree-clean
branch
from
13544c2 to
fd3bd4f
Compare
Owner
|
Now this can be rebased as well :) |
jensenr30
force-pushed
the
working-tree-clean
branch
from
fd3bd4f to
0c549c7
Compare
Contributor
Author
|
Hmmm... Looks like I broke some tests... I'll look into this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no changes in the working directory, the top placeholder commit says "Working tree clean".
I added a function
bool is_working_tree_clean(void) constinclass CommitModel : public QAbstractListModel. Is there a better place to put this function? I'm a C++ beginner. I was trying to figure out how to access theis_working_tree_clean()function in other places inCommitList.cppbut couldn't figure out a clean way to do it...Resolves #704