Merged
Conversation
ExpertLS for Elixir is going to be the future of LSP for Elixir so we're going to start working with that. It's only pre-release and it would be prudent to also keep expecting .elixir_ls directories as well since we may switch back and forth some. Note that these exclusions are really only needed in the Elixir project gitignores.
Currently the Elixir ExpertLS extension for VS Code wants to log its activities in whatever the first directory in the VS Code workspace is, without regard to even if the project is an elixir project. We'll open an issue with the ExpertLS team, but in the meantime we'll just satisfy the requirement by adding a special top level directory to the workspace and then ignoring anything in that directory.
Update the clean_ls function to also clean the .expert directory. We won't remove the .elixir_ls part of the function at this point since we may still switch back. Similarly update the new project scaffold .gitignore to also ignore the .expert directory of any new project.
✅ Deploy Preview for musedocs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpertLS for Elixir is going to be the future of LSP for Elixir so
we're going to start working with that. It's only pre-release and it
would be prudent to also keep expecting ElixirLS artifacts as
well since we may switch back and forth some.