Skip to content

Android updates#2206

Merged
MaxKellermann merged 14 commits intoMusicPlayerDaemon:masterfrom
geneticdrift:android-updates
Feb 13, 2025
Merged

Android updates#2206
MaxKellermann merged 14 commits intoMusicPlayerDaemon:masterfrom
geneticdrift:android-updates

Conversation

@geneticdrift
Copy link
Contributor

No description provided.

@MaxKellermann
Copy link
Member

What are these .idea files? Are they necessary to build MPD?

…NAL_STORAGE, added permission READ_MEDIA_AUDIO

Change fo r SDK version 33 and above
…ationale is false

Android will ignore permission request and will not show the request dialog
if the user's action implies "don't ask again."
This leaves the app in a crippled state and the user confused.
Google says "don't try to convince the user", so it returns false for `shouldShowRequestPermissionRationale`.

To help the user proceed, we show the `Request permission` button only if `shouldShowRequestPermissionRationale == true`
because there's a good chance the premission request dialog will not be ignored.

If `shouldShowRequestPermissionRationale == false` we instead show the "rationale" message and a button to open
the app info dialog where the user can explicitly grand the permission.
… and service.

Loader converted from java to kotlin.

Instead of loading libmpd when the service thread is started,
the service will not start the the thread if libmpd failed to load.

The loader is also accessed by the view data to let
the ui adjust if failed to load, by showing the failure reason
and disabling the Start MPD button.
@MaxKellermann MaxKellermann merged commit f1e43cb into MusicPlayerDaemon:master Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants