feat(web): add password visibility toggle on login #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add horizontal scroll navigation with chevron buttons for AdminTabs - Implement flex-1 layout for tabs to fill available width on large screens - Add smooth scrolling and scroll state detection for small screens - Ensure tab borders align with main content container - Update all tab components (AdminTabs, ApiDocsTabs, ConsumptionTabs) for consistency 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
- Add horizontal scroll navigation with chevron buttons for AdminTabs - Implement flex-1 layout for tabs to fill available width on large screens - Add smooth scrolling and scroll state detection for small screens - Ensure tab borders align with main content container - Update all tab components (AdminTabs, ApiDocsTabs, ConsumptionTabs) 🤖 Generated with Claude Code Co-authored-by: Clément VALENTIN <[email protected]> Co-authored-by: Claude <[email protected]>
…g UI (#43) Fixed NameError in /admin/stats endpoint caused by missing cache_service import. Added proper loading state using LoadingOverlay component with blur effect. Extended LoadingOverlay to support 'admin' data type with appropriate messages. 🤖 Generated with Claude Code Co-authored-by: Clément VALENTIN <[email protected]> Co-authored-by: Claude <[email protected]>
The previous package-lock.json was missing tree-sitter dependencies ([email protected] and [email protected]), causing `npm ci` to fail during Docker builds with the error "package.json and package-lock.json are not in sync". This regenerates the lock file to include all required dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Clément VALENTIN <[email protected]> Co-authored-by: Claude <[email protected]>
Add eye icon button to show/hide password in the login form for better UX. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Reverts accidental removal of tree-sitter peer dependencies that broke npm ci in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull request overview
This pull request adds a password visibility toggle to the login form and includes several additional improvements to the admin interface and tab navigation components.
Key Changes
- Added password visibility toggle with eye/eye-off icons on the login page
- Implemented loading and error states for the Admin dashboard
- Enhanced tab navigation with responsive layouts and horizontal scrolling for AdminTabs
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/pages/Login.tsx | Added password visibility toggle with state management and accessibility features |
| apps/web/src/pages/Admin.tsx | Added loading and error state handling with LoadingOverlay component |
| apps/web/src/components/LoadingOverlay.tsx | Added 'admin' dataType support for admin page loading states |
| apps/web/src/components/ConsumptionTabs.tsx | Restructured layout with container wrapper and improved responsive design |
| apps/web/src/components/ApiDocsTabs.tsx | Restructured layout consistent with other tab components |
| apps/web/src/components/AdminTabs.tsx | Added horizontal scroll functionality with scroll indicators and improved layout |
| apps/web/package-lock.json | Updated TypeScript ESLint packages from 8.48.0 to 8.48.1 and other minor dependency updates |
| apps/api/src/routers/admin.py | Added cache_service import for cache management functionality |
Files not reviewed (1)
- apps/web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+44
| useEffect(() => { | ||
| checkScroll() | ||
| window.addEventListener('resize', checkScroll) | ||
| return () => window.removeEventListener('resize', checkScroll) | ||
| }, []) |
There was a problem hiding this comment.
The useEffect hook should include visibleTabs in its dependency array. When the visible tabs change (e.g., due to permission changes), the scroll state should be recalculated. Consider adding checkScroll to the dependency array and ensuring it's properly memoized with useCallback, or add visibleTabs to trigger recalculation when tabs visibility changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add eye icon button to show/hide password in the login form for improved user experience.
Changes
🤖 Generated with Claude Code