Hide linked production PDLs from selector #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug where linked_production_pdl_id uses UUID instead of usage_point_id - Move linkedProductionIds calculation outside production page logic - Apply global filter to hide production PDLs linked to consumption PDLs - Ensures only consumption PDLs appear in selectors when production is linked 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in PDL (Point De Livraison / delivery point) filtering logic and implements global hiding of production PDLs that are linked to consumption PDLs. The bug occurred because linked_production_pdl_id stores the UUID (pdl.id), but the comparison was incorrectly using pdl.usage_point_id, causing linked production PDLs to not be properly filtered out.
Key Changes:
- Fixed incorrect field comparison in production PDL filtering (using
pdl.idinstead ofpdl.usage_point_id) - Moved
linkedProductionIdscalculation outside production-specific logic for reuse across all pages - Extended filtering to hide linked production PDLs globally across all page selectors, ensuring only consumption PDLs are displayed when production is linked
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
linked_production_pdl_idcomparison uses UUID instead ofusage_point_idTest plan