Skip to content

Conversation

@m4dm4rtig4n
Copy link
Contributor

Summary

Fixed Conductor app detection by simplifying the conductor.json configuration to use the supported format with setup and run scripts. The previous custom structure with onStart, services, infrastructure properties was not recognized by the Conductor app.

Changes

  • Replaced unsupported custom configuration with standard Conductor format
  • setup script: Starts services with dynamic port allocation
  • run script: Displays live logs from frontend and backend containers

Testing

The workspace can now be properly initialized in Conductor with dynamic port assignment and multi-instance deployment support.

🤖 Generated with Claude Code

Update conductor.json to use the correct Conductor app format with only
'setup' and 'run' scripts. This enables dynamic port allocation and proper
service initialization. Removes unsupported custom properties.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings December 5, 2025 23:03
@m4dm4rtig4n m4dm4rtig4n merged commit a39425a into main Dec 5, 2025
8 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Conductor configuration file to use a format that is properly recognized by the Conductor app. The previous custom structure with onStart, services, and infrastructure properties has been replaced with a minimal configuration containing only setup and run scripts.

Key Changes:

  • Removed unsupported custom configuration structure (77 lines)
  • Added minimal scripts section with setup and run commands
  • Delegated all complex logic to the existing conductor-start.sh script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"COMPOSE_PROJECT_NAME": "med-${CONDUCTOR_BRANCH_SLUG}",
"CONDUCTOR_BRANCH_SLUG": "${CONDUCTOR_BRANCH_SLUG:-dev}"
"setup": "./scripts/conductor-start.sh",
"run": "docker compose -f docker-compose.conductor.yml -f docker-compose.override.yml logs -f frontend backend"
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run script references docker-compose.override.yml, but this file is generated by the setup script (conductor-start.sh at line 119-140). If Conductor runs the run command before the setup command has completed, or if docker-compose.override.yml doesn't exist, this command will fail.

Consider either:

  1. Making the command more resilient by checking if the override file exists, or
  2. Using environment variables exported by the setup script instead of relying on the generated override file, or
  3. Adding a comment in the configuration to document this dependency

Example resilient approach:

"run": "[ -f docker-compose.override.yml ] && docker compose -f docker-compose.conductor.yml -f docker-compose.override.yml logs -f frontend backend || echo 'Setup not complete. Run setup first.'"
Suggested change
"run": "docker compose -f docker-compose.conductor.yml -f docker-compose.override.yml logs -f frontend backend"
"run": "[ -f docker-compose.override.yml ] && docker compose -f docker-compose.conductor.yml -f docker-compose.override.yml logs -f frontend backend || echo 'Setup not complete. Run setup first.'"

Copilot uses AI. Check for mistakes.
@m4dm4rtig4n m4dm4rtig4n deleted the fix-conductor-detection branch December 18, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants