[CLEANUP] Avoid Hungarian notation in DeclarationBlock
#1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
Also fix some variable name collisions. Part of #756
oliverklee
force-pushed
the
cleanup/hungarian/declaration-block
branch
from
b8b058c to
dc0bd3b
Compare
JakeQZ
requested changes
Feb 26, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
The changes to avoid variable name collisions are good, but I'm a bit unsure about one of the renames.
src/RuleSet/DeclarationBlock.php
Outdated
Comment on lines
126
to
127
| foreach ($this->selectors as $key => $subSelector) { | ||
| if ($subSelector->getSelector() === $selectorToRemove) { |
Collaborator
There was a problem hiding this comment.
I think $selector singular was fine here for the loop variable. $subSelector is a strange name. (The parameter name change is good.)
JakeQZ
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some variable name collisions.
Part of #756