[CLEANUP] Avoid Hungarian notation for rules
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
cleanup/hungarian/rules
branch
from
06a14f2 to
c70a770
Compare
JakeQZ
approved these changes
Feb 27, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
The change is fine. I'm struggling to understand the original implementation.
Comment on lines
+274
to
+275
| foreach ($this->rules as $rules) { | ||
| foreach ($rules as $rule) { |
Collaborator
There was a problem hiding this comment.
I'm struggling to understand how and why this can be doubly-iterated over - since Rule does not appear to be Iterable.
Collaborator
Author
There was a problem hiding this comment.
I don’t understand this either. Either this is broken (and not tested, or never called), or the code somehow still is working fine. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #756