Skip to content

[CLEANUP] Refactor CSSBlockList::getAllRuleSets() #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

[CLEANUP] Refactor CSSBlockList::getAllRuleSets() #1050

merged 1 commit into from
Mar 2, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Mar 2, 2025

Also remove the now-unused method allRuleSets().

Part of #994.

@oliverklee
[CLEANUP] Refactor CSSBlockList::getAllRuleSets()
82667e2 
Also remove the now-unused method `allRuleSets()`.

Part of #994.
@oliverklee oliverklee requested a review from JakeQZ March 2, 2025 18:51
@oliverklee oliverklee self-assigned this Mar 2, 2025
@coveralls
Copy link

coveralls commented Mar 2, 2025

Coverage Status

coverage: 55.73% (-0.07%) from 55.799%
when pulling 82667e2 on cleanup/refactor/get-all-rulesets
into f912e71 on main.

@JakeQZ JakeQZ merged commit 54ca442 into main Mar 2, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/refactor/get-all-rulesets branch March 2, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ