[BUGFIX] Fix a type annotation in RuleSet
#1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
reviewed
Mar 3, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I figured out why the Rules in RuleSet are a nested array. The top-level key is the property name. But since it's possible to have multiple rules for the same property, the values are (non-associative) arrays of Rules. The problem with this structure is that the ordering is lost, and we have #1052.
Anyway, I think the keys are always property names (whatever the RuleSet type), and there isn't really a concept of a 'rule name'.
oliverklee
force-pushed
the
bugfix/type-annotation/ruleset
branch
from
3dcdca4 to
df45995
Compare
Collaborator
Author
|
I've updated the comment accordingly (and also the variables names in #1039). |
oliverklee
force-pushed
the
bugfix/type-annotation/ruleset
branch
from
df45995 to
86e5460
Compare
JakeQZ
approved these changes
Mar 3, 2025
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1051.
JakeQZ
pushed a commit
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.