-
Notifications
You must be signed in to change notification settings - Fork 149
[BUGFIX] Render rules in line and column number order #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b9fc6aa to
526208f
Compare
|
This seems to break (or change) shorthand expansion. Also, the results seem be depend on the PHP version (2 failures with PHP 8.4, 17 failures with PHP 5.6). I'd suggest we don't backport this after all as getting this to work consistently across PHP versions might not be worth the hassle. (And I'm not keen on doing the work.) What do you think, @JakeQZ? |
526208f to
938e6b4
Compare
|
… or we remove the failing tests, or we remodel them to not care about the order of things anymore. |
The tests seem to expect a spefic ordering of the expanded shorthand properties, when in fact it doesn't matter. Since they all came from the same original property, they probably have the same line number, so when passed to
That would allow the backport.
I'm happy to try to create a pre-PR to change the tests. |
This is a pre-patch for #1062.
This is the V8.x backport of #1059.
938e6b4 to
435a086
Compare
This is the V8.x backport of #1059.