Skip to content

Conversation

@oliverklee
Copy link
Collaborator

This is the V8.x backport of #1059.

@oliverklee oliverklee self-assigned this Mar 4, 2025
@oliverklee oliverklee force-pushed the backport/bugfix/render-rules branch 2 times, most recently from b9fc6aa to 526208f Compare March 4, 2025 08:32
@oliverklee
Copy link
Collaborator Author

This seems to break (or change) shorthand expansion. Also, the results seem be depend on the PHP version (2 failures with PHP 8.4, 17 failures with PHP 5.6).

I'd suggest we don't backport this after all as getting this to work consistently across PHP versions might not be worth the hassle. (And I'm not keen on doing the work.)

What do you think, @JakeQZ?

@oliverklee oliverklee marked this pull request as draft March 4, 2025 08:39
@oliverklee oliverklee force-pushed the backport/bugfix/render-rules branch from 526208f to 938e6b4 Compare March 4, 2025 10:18
@oliverklee
Copy link
Collaborator Author

… or we remove the failing tests, or we remodel them to not care about the order of things anymore.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 4, 2025

This seems to break (or change) shorthand expansion. Also, the results seem be depend on the PHP version (2 failures with PHP 8.4, 17 failures with PHP 5.6).

The tests seem to expect a spefic ordering of the expanded shorthand properties, when in fact it doesn't matter. Since they all came from the same original property, they probably have the same line number, so when passed to usort, the resulting order could be any. The number of failures with different PHP versions probably depends on the internal implementation of usort for the PHP version.

or we remodel them to not care about the order of things anymore.

That would allow the backport.

(And I'm not keen on doing the work.)

I'm happy to try to create a pre-PR to change the tests.

JakeQZ added a commit that referenced this pull request Mar 4, 2025
JakeQZ added a commit that referenced this pull request Mar 4, 2025
JakeQZ added a commit that referenced this pull request Mar 4, 2025
oliverklee pushed a commit that referenced this pull request Mar 4, 2025
@oliverklee oliverklee force-pushed the backport/bugfix/render-rules branch from 938e6b4 to 435a086 Compare March 4, 2025 12:39
@oliverklee oliverklee marked this pull request as ready for review March 4, 2025 12:41
@oliverklee oliverklee requested a review from JakeQZ March 4, 2025 12:41
@JakeQZ JakeQZ merged commit 6543eb2 into v8.x Mar 4, 2025
22 checks passed
@JakeQZ JakeQZ deleted the backport/bugfix/render-rules branch March 4, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants