Skip to content

[CLEANUP] Avoid Hungarian notation for isColorComponent #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
+8 −8
Merged

[CLEANUP] Avoid Hungarian notation for isColorComponent #1090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Value/Size.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,31 +65,31 @@ class Size extends PrimitiveValue
/**
* @var bool
*/
private $bIsColorComponent;
private $isColorComponent;

/**
* @param float|int|string $size
* @param string|null $unit
* @param bool $bIsColorComponent
* @param bool $isColorComponent
* @param int<0, max> $lineNumber
*/
public function __construct($size, $unit = null, $bIsColorComponent = false, $lineNumber = 0)
public function __construct($size, $unit = null, $isColorComponent = false, $lineNumber = 0)
{
parent::__construct($lineNumber);
$this->size = (float) $size;
$this->unit = $unit;
$this->bIsColorComponent = $bIsColorComponent;
$this->isColorComponent = $isColorComponent;
}

/**
* @param bool $bIsColorComponent
* @param bool $isColorComponent
*
* @throws UnexpectedEOFException
* @throws UnexpectedTokenException
*
* @internal since V8.8.0
*/
public static function parse(ParserState $parserState, $bIsColorComponent = false): Size
public static function parse(ParserState $parserState, $isColorComponent = false): Size
{
$size = '';
if ($parserState->comes('-')) {
Expand Down Expand Up @@ -121,7 +121,7 @@ public static function parse(ParserState $parserState, $bIsColorComponent = fals
}
}
}
return new Size((float) $size, $unit, $bIsColorComponent, $parserState->currentLine());
return new Size((float) $size, $unit, $isColorComponent, $parserState->currentLine());
}

/**
Expand Down Expand Up @@ -182,7 +182,7 @@ public function getSize()
*/
public function isColorComponent()
{
return $this->bIsColorComponent;
return $this->isColorComponent;
}

/**
Expand Down