Skip to content

[CLEANUP] Ignore warnings for explicitly invalid values in tests #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CLEANUP] Ignore warnings for explicitly invalid values in tests #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions config/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,3 @@ parameters:
identifier: argument.type
count: 2
path: ../tests/Unit/CSSList/CSSListTest.php

-
message: '#^Parameter \#3 \$matchType of class Sabberworm\\CSS\\Parsing\\UnexpectedEOFException constructor expects ''count''\|''custom''\|''expression''\|''identifier''\|''literal''\|''search'', ''coding'' given\.$#'
identifier: argument.type
count: 1
path: ../tests/Unit/Parsing/UnexpectedEOFExceptionTest.php

-
message: '#^Parameter \#3 \$matchType of class Sabberworm\\CSS\\Parsing\\UnexpectedTokenException constructor expects ''count''\|''custom''\|''expression''\|''identifier''\|''literal''\|''search'', ''coding'' given\.$#'
identifier: argument.type
count: 1
path: ../tests/Unit/Parsing/UnexpectedTokenExceptionTest.php
1 change: 1 addition & 0 deletions tests/Unit/Parsing/UnexpectedEOFExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public function messageForInvalidMatchTypeRefersToTokenNotFound(): void
$expected = 'tea';
$found = 'coffee';

// @phpstan-ignore-next-line argument.type We're explicitly testing with an invalid value here.
$exception = new UnexpectedEOFException($expected, $found, 'coding');

$expectedMessage = 'Token “' . $expected . '” (coding) not found. Got “' . $found . '”.';
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/Parsing/UnexpectedTokenExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public function messageForInvalidMatchTypeRefersToTokenNotFound(): void
$expected = 'tea';
$found = 'coffee';

// @phpstan-ignore-next-line argument.type We're explicitly testing with an invalid value here.
$exception = new UnexpectedTokenException($expected, $found, 'coding');

$expectedMessage = 'Token “' . $expected . '” (coding) not found. Got “' . $found . '”.';
Expand Down