Skip to content

Conversation

@oliverklee
Copy link
Collaborator

We'll rework and sort the tests into these folders:

  • Unit and Functional: for tests that do not call deprecated methods, and where PHPUnit should warn if deprecated methods are called
  • UnitDeprecated and FunctionalDeprecated: for tests that call deprecated methods, and where PHPUnit should not warn about those

For the time being, we still call all tests with the same configuration.

We'll rework and sort the tests into these folders:

- `Unit` and `Functional`: for tests that do not call deprecated methods,
  and where PHPUnit should warn if deprecated methods are called
- `UnitDeprecated` and `FunctionalDeprecated`: for tests that call
  deprecated methods, and where PHPUnit should not warn about those

For the time being, we still call all tests with the same configuration.
@coveralls
Copy link

Coverage Status

coverage: 38.622%. remained the same
when pulling e51b720 on task/tests-folders
into 53c5210 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I presume the .gitkeep files will be removed as soon as there's something in these directories.

@JakeQZ JakeQZ merged commit 7a29455 into main Oct 30, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/tests-folders branch October 30, 2024 22:43
@oliverklee
Copy link
Collaborator Author

I presume the .gitkeep files will be removed as soon as there's something in these directories.

Yes, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants