[BUGFIX] Parse @font-face src property as comma-delimited list #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #789. Also adds an initial `TestCase` for `Rule/Rule`.
JakeQZ
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
requested changes
Jan 17, 2025
Collaborator
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
Looks generally very good!
I've added some comments regarding readability.
oliverklee
reviewed
Jan 17, 2025
Collaborator
Author
I've made some changes and replied to those comments. |
oliverklee
requested changes
Jan 17, 2025
tests/Unit/Rule/RuleTest.php
Outdated
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sabberworm\CSS\Tests\Value; |
Collaborator
There was a problem hiding this comment.
Suggested change
| namespace Sabberworm\CSS\Tests\Value; | |
| namespace Sabberworm\CSS\Tests\Unit\Value; |
Collaborator
Author
There was a problem hiding this comment.
It lost my comment.
The namespace should also have been Rule not Value - mistake arising from copying and pasting from another file as a template.
tests/Unit/Rule/RuleTest.php
Outdated
| final class RuleTest extends TestCase | ||
| { | ||
| /** | ||
| * @return array<string, array{0: string, 1: list<class-string>}> |
Collaborator
There was a problem hiding this comment.
Suggested change
| * @return array<string, array{0: string, 1: list<class-string>}> | |
| * @return array<string, array{0: string, 1: list<class-string>}> |
oliverklee
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #789.
Also adds an initial
TestCaseforRule/Rule.