Skip to content

Conversation

@oliverklee
Copy link
Collaborator

Also make then static if possible.

@coveralls
Copy link

coveralls commented Jan 28, 2025

Coverage Status

coverage: 44.039%. remained the same
when pulling 30a1120 on cleanup/static-functions
into 436a954 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but think a couple more closures can be made static, while we're here.

@oliverklee oliverklee force-pushed the cleanup/static-functions branch from 694d510 to 30a1120 Compare January 28, 2025 22:31
@oliverklee oliverklee requested a review from JakeQZ January 28, 2025 22:32
@JakeQZ JakeQZ merged commit bd206a2 into main Jan 28, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/static-functions branch January 28, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants