Skip to content

[CLEANUP] Extract method Color::shouldRenderAsHex #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

[CLEANUP] Extract method Color::shouldRenderAsHex #853

merged 1 commit into from
Jan 30, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jan 30, 2025

Resolves #852.

@JakeQZ JakeQZ added the cleanup label Jan 30, 2025
@JakeQZ JakeQZ requested a review from oliverklee January 30, 2025 20:33
@JakeQZ JakeQZ self-assigned this Jan 30, 2025
@oliverklee oliverklee enabled auto-merge (squash) January 30, 2025 20:34
@oliverklee oliverklee merged commit 3a147fd into main Jan 30, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/color/should-render-hex branch January 30, 2025 20:34
@coveralls
Copy link

coveralls commented Jan 30, 2025

Coverage Status

coverage: 45.068% (+0.06%) from 45.006%
when pulling 7dc3be2 on cleanup/color/should-render-hex
into c8a7b5f on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

Add Color::shouldRenderInHexSyntax method

4 participants

@JakeQZ @coveralls @oliverklee