-
Notifications
You must be signed in to change notification settings - Fork 150
[TASK] Add tests for the exceptions #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sabberworm\CSS\Tests\Unit\Parsing; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Sabberworm\CSS\Parsing\OutputException; | ||
| use Sabberworm\CSS\Parsing\SourceException; | ||
|
|
||
| /** | ||
| * @covers \Sabberworm\CSS\Parsing\OutputException | ||
| */ | ||
| final class OutputExceptionTest extends TestCase | ||
| { | ||
| /** | ||
| * @test | ||
| */ | ||
| public function extendsSourceException(): void | ||
| { | ||
| self::assertInstanceOf(SourceException::class, new OutputException('foo')); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getMessageReturnsMessageProvidedToConstructor(): void | ||
| { | ||
| $message = 'The cake is a lie.'; | ||
| $exception = new OutputException($message); | ||
|
|
||
| self::assertStringContainsString($message, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoByDefaultReturnsZero(): void | ||
| { | ||
| $exception = new OutputException('foo'); | ||
|
|
||
| self::assertSame(0, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoReturnsLineNumberProvidedToConstructor(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new OutputException('foo', $lineNumber); | ||
|
|
||
| self::assertSame($lineNumber, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getMessageWithLineNumberProvidedIncludesLineNumber(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new OutputException('foo', $lineNumber); | ||
|
|
||
| self::assertStringContainsString(' [line no: ' . $lineNumber . ']', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function canBeThrown(): void | ||
oliverklee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| $this->expectException(OutputException::class); | ||
|
|
||
| throw new OutputException('foo'); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sabberworm\CSS\Tests\Unit\Parsing; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Sabberworm\CSS\Parsing\SourceException; | ||
|
|
||
| /** | ||
| * @covers \Sabberworm\CSS\Parsing\SourceException | ||
| */ | ||
| final class SourceExceptionTest extends TestCase | ||
| { | ||
| /** | ||
| * @test | ||
| */ | ||
| public function getMessageReturnsMessageProvidedToConstructor(): void | ||
| { | ||
| $message = 'The cake is a lie.'; | ||
| $exception = new SourceException($message); | ||
|
|
||
| self::assertStringContainsString($message, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoByDefaultReturnsZero(): void | ||
| { | ||
| $exception = new SourceException('foo'); | ||
|
|
||
| self::assertSame(0, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoReturnsLineNumberProvidedToConstructor(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new SourceException('foo', $lineNumber); | ||
|
|
||
| self::assertSame($lineNumber, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getMessageWithLineNumberProvidedIncludesLineNumber(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new SourceException('foo', $lineNumber); | ||
|
|
||
| self::assertStringContainsString(' [line no: ' . $lineNumber . ']', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function canBeThrown(): void | ||
| { | ||
| $this->expectException(SourceException::class); | ||
|
|
||
| throw new SourceException('foo'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sabberworm\CSS\Tests\Unit\Parsing; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Sabberworm\CSS\Parsing\UnexpectedEOFException; | ||
| use Sabberworm\CSS\Parsing\UnexpectedTokenException; | ||
|
|
||
| /** | ||
| * @covers \Sabberworm\CSS\Parsing\UnexpectedEOFException | ||
| */ | ||
| final class UnexpectedEOFExceptionTest extends TestCase | ||
| { | ||
| /** | ||
| * @test | ||
| */ | ||
| public function extendsUnexpectedTokenException(): void | ||
| { | ||
| self::assertInstanceOf(UnexpectedTokenException::class, new UnexpectedEOFException('expected', 'found')); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoByDefaultReturnsZero(): void | ||
| { | ||
| $exception = new UnexpectedEOFException('expected', 'found'); | ||
|
|
||
| self::assertSame(0, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getLineNoReturnsLineNumberProvidedToConstructor(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new UnexpectedEOFException('expected', 'found', 'literal', $lineNumber); | ||
|
|
||
| self::assertSame($lineNumber, $exception->getLineNo()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function getMessageWithLineNumberProvidedIncludesLineNumber(): void | ||
| { | ||
| $lineNumber = 17; | ||
| $exception = new UnexpectedEOFException('expected', 'found', 'literal', $lineNumber); | ||
|
|
||
| self::assertStringContainsString(' [line no: ' . $lineNumber . ']', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function canBeThrown(): void | ||
| { | ||
| $this->expectException(UnexpectedEOFException::class); | ||
|
|
||
| throw new UnexpectedEOFException('expected', 'found'); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageByDefaultRefersToTokenNotFound(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found); | ||
|
|
||
| $expectedMessage = 'Token “' . $expected . '” (literal) not found. Got “' . $found . '”.'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForInvalidMatchTypeRefersToTokenNotFound(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'coding'); | ||
|
|
||
| $expectedMessage = 'Token “' . $expected . '” (coding) not found. Got “' . $found . '”.'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForLiteralMatchTypeRefersToTokenNotFound(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'literal'); | ||
|
|
||
| $expectedMessage = 'Token “' . $expected . '” (literal) not found. Got “' . $found . '”.'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForSearchMatchTypeRefersToNoResults(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'search'); | ||
|
|
||
| $expectedMessage = 'Search for “' . $expected . '” returned no results. Context: “' . $found . '”.'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForCountMatchTypeRefersToNumberOfCharacters(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'count'); | ||
|
|
||
| $expectedMessage = 'Next token was expected to have ' . $expected . ' chars. Context: “' . $found . '”.'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForIdentifierMatchTypeRefersToIdentifier(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'identifier'); | ||
|
|
||
| $expectedMessage = 'Identifier expected. Got “' . $found . '”'; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForCustomMatchTypeMentionsExpectedAndFound(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException($expected, $found, 'custom'); | ||
|
|
||
| $expectedMessage = $expected . ' ' . $found; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function messageForCustomMatchTypeTrimsMessage(): void | ||
| { | ||
| $expected = 'tea'; | ||
| $found = 'coffee'; | ||
|
|
||
| $exception = new UnexpectedEOFException(' ' . $expected, $found . ' ', 'custom'); | ||
|
|
||
| $expectedMessage = $expected . ' ' . $found; | ||
| self::assertStringContainsString($expectedMessage, $exception->getMessage()); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.