-
Notifications
You must be signed in to change notification settings - Fork 150
[TASK] Move some tests for Comment to functional tests
#912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f53dab to
f8e6219
Compare
JakeQZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests for 'pretty' and 'compact' should actually use the applicable creation methods.
Perhaps there should also be a test for the create method, as well as construction with new.
Move the tests that rely on another class (`OutputFormat`) (or might in the future). Part of #757.
f8e6219 to
126e148
Compare
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
f86244e to
a470b6c
Compare
|
Done and repushed. |
JakeQZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virgin was an interesting choice for the test method name, and slightly amusing, but works :)
I actually was struggling with the name a bit. A close contender was "newly minted". Any other suggestions (from a native BE speaker)? |
Coincidentally, I just listened to a programme about cooking oils. You might not be able to access it outside the UK. 14 minutes in the 'expert' talks about olive oil, and says: "Extra virgin overall means it's as close to the natural state as possible." So I think you've hit the nomeclature nail directly on the head here, and the naming cannot be improvied upon. Well done. (Virgin does not always imply lack of promiscuity, particularly when applied to inanimate objects.) Freshly-minted has a strong association with the bank prressing coins. It would not have worked as well, but would have been acceptably whimsical :)) |
Move the tests that rely on another class (
OutputFormat) (or might in the future).Part of #757.