Skip to content

Conversation

@oliverklee
Copy link
Collaborator

Move the tests that rely on another class (OutputFormat) (or might in the future).

Part of #757.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for 'pretty' and 'compact' should actually use the applicable creation methods.

Perhaps there should also be a test for the create method, as well as construction with new.

@coveralls
Copy link

coveralls commented Feb 13, 2025

Coverage Status

coverage: 49.156%. remained the same
when pulling f86244e on task/comment-test
into 537f5e8 on main.

Move the tests that rely on another class (`OutputFormat`)
(or might in the future).

Part of #757.
@oliverklee
Copy link
Collaborator Author

Done and repushed.

@oliverklee oliverklee removed the request for review from sabberworm February 13, 2025 19:45
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virgin was an interesting choice for the test method name, and slightly amusing, but works :)

@JakeQZ JakeQZ merged commit 6057847 into main Feb 14, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/comment-test branch February 14, 2025 01:17
@oliverklee
Copy link
Collaborator Author

Virgin was an interesting choice for the test method name, and slightly amusing, but works :)

I actually was struggling with the name a bit. A close contender was "newly minted". Any other suggestions (from a native BE speaker)?

@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 15, 2025

Virgin was an interesting choice for the test method name, and slightly amusing, but works :)

I actually was struggling with the name a bit. A close contender was "newly minted". Any other suggestions (from a native BE speaker)?

Coincidentally, I just listened to a programme about cooking oils. You might not be able to access it outside the UK. 14 minutes in the 'expert' talks about olive oil, and says: "Extra virgin overall means it's as close to the natural state as possible."

So I think you've hit the nomeclature nail directly on the head here, and the naming cannot be improvied upon. Well done. (Virgin does not always imply lack of promiscuity, particularly when applied to inanimate objects.)

Freshly-minted has a strong association with the bank prressing coins. It would not have worked as well, but would have been acceptably whimsical :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants