[TASK] Drop redundant OutputException constructor
#925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
reviewed
Feb 15, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
There is an issue with PHP and undefined constructors, which is why I always provide an empty constructor in the base class. I can't recall the details. I don't think that's a problem here, but will need to check.
oliverklee
force-pushed
the
cleanup/redundant-exceptions
branch
from
3dcc81a to
70fbfd1
Compare
Collaborator
Author
|
In this case, the direct parent class |
oliverklee
force-pushed
the
cleanup/redundant-exceptions
branch
from
70fbfd1 to
2ed8ad3
Compare
Collaborator
That was for a different class (
I missed that comment before commenting on having reached the same conclusion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.