[TASK] Narrow the some type annotations in OutputFormatter
#945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/formatter-annotations
branch
from
6dfc13f to
7ad908d
Compare
JakeQZ
requested changes
Feb 16, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I think the list argument separators are necessarily non-empty strings, but the 'glue' for implode() doesn't have to be.
JakeQZ
reviewed
Feb 16, 2025
src/OutputFormatter.php
Outdated
| /** | ||
| * Clone of the `implode` function, but calls `render` with the current output format instead of `__toString()`. | ||
| * | ||
| * @param non-empty-string $sSeparator |
Collaborator
There was a problem hiding this comment.
There might be use cases where this is an empty string, for example concatenating hex colour values ['r' => '00', 'g' => 'FF', 'b' => '00'].
Given that the inbuilt implode() that this is based on accepts an empty string as the $glue parameter, I would prefer not to change this. I note that the PHP docs have renamed this parameter since PHP 8 to $separator. However, IMO that is a misnomer, implying, um, separation, which an empty string (the default) does not achieve.
oliverklee
force-pushed
the
task/formatter-annotations
branch
from
7ad908d to
eac45ae
Compare
Collaborator
Author
|
Good point! Changed and repushed. |
JakeQZ
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.