Skip to content

[CLEANUP] Avoid Hungarian notation for length #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[CLEANUP] Avoid Hungarian notation for length #950

merged 1 commit into from
Feb 18, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 18, 2025

Part of #756

@oliverklee oliverklee requested a review from JakeQZ February 18, 2025 09:33
@oliverklee oliverklee self-assigned this Feb 18, 2025
@coveralls
Copy link

coveralls commented Feb 18, 2025

Coverage Status

coverage: 51.335%. remained the same
when pulling c7f8931 on cleanup/hungarian/length
into 0cf4a76 on main.

JakeQZ
JakeQZ approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has reminded me to add #953.

@JakeQZ JakeQZ merged commit 0079925 into main Feb 18, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/length branch February 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ