Skip to content

[CLEANUP] Avoid Hungarian notation for ignoreCase #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Avoid Hungarian notation for ignoreCase #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Parsing/ParserState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ public function setPosition($position): void
}

/**
* @param bool $bIgnoreCase
* @param bool $ignoreCase
*
* @return string
*
* @throws UnexpectedTokenException
*/
public function parseIdentifier($bIgnoreCase = true)
public function parseIdentifier($ignoreCase = true)
{
if ($this->isEnd()) {
throw new UnexpectedEOFException('', '', 'identifier', $this->lineNumber);
Expand All @@ -141,7 +141,7 @@ public function parseIdentifier($bIgnoreCase = true)
$result .= '\\' . $sCharacter;
}
}
if ($bIgnoreCase) {
if ($ignoreCase) {
$result = $this->strtolower($result);
}
return $result;
Expand Down
8 changes: 4 additions & 4 deletions src/Value/CSSFunction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ public function __construct($sName, $aArguments, $sSeparator = ',', $lineNumber
*
* @internal since V8.8.0
*/
public static function parse(ParserState $parserState, bool $bIgnoreCase = false): CSSFunction
public static function parse(ParserState $parserState, bool $ignoreCase = false): CSSFunction
{
$sName = self::parseName($parserState, $bIgnoreCase);
$sName = self::parseName($parserState, $ignoreCase);
$parserState->consume('(');
$mArguments = self::parseArguments($parserState);

Expand All @@ -64,9 +64,9 @@ public static function parse(ParserState $parserState, bool $bIgnoreCase = false
* @throws UnexpectedEOFException
* @throws UnexpectedTokenException
*/
private static function parseName(ParserState $parserState, bool $bIgnoreCase = false): string
private static function parseName(ParserState $parserState, bool $ignoreCase = false): string
{
return $parserState->parseIdentifier($bIgnoreCase);
return $parserState->parseIdentifier($ignoreCase);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Value/CalcFunction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class CalcFunction extends CSSFunction
*
* @internal since V8.8.0
*/
public static function parse(ParserState $parserState, bool $bIgnoreCase = false): CSSFunction
public static function parse(ParserState $parserState, bool $ignoreCase = false): CSSFunction
{
$aOperators = ['+', '-', '*', '/'];
$sFunction = $parserState->parseIdentifier();
Expand Down
8 changes: 4 additions & 4 deletions src/Value/Value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public static function parseValue(ParserState $parserState, array $aListDelimite
}

/**
* @param bool $bIgnoreCase
* @param bool $ignoreCase
*
* @return CSSFunction|string
*
Expand All @@ -119,10 +119,10 @@ public static function parseValue(ParserState $parserState, array $aListDelimite
*
* @internal since V8.8.0
*/
public static function parseIdentifierOrFunction(ParserState $parserState, $bIgnoreCase = false)
public static function parseIdentifierOrFunction(ParserState $parserState, $ignoreCase = false)
{
$oAnchor = $parserState->anchor();
$result = $parserState->parseIdentifier($bIgnoreCase);
$result = $parserState->parseIdentifier($ignoreCase);

if ($parserState->comes('(')) {
$oAnchor->backtrack();
Expand All @@ -135,7 +135,7 @@ public static function parseIdentifierOrFunction(ParserState $parserState, $bIgn
) {
$result = CalcFunction::parse($parserState);
} else {
$result = CSSFunction::parse($parserState, $bIgnoreCase);
$result = CSSFunction::parse($parserState, $ignoreCase);
}
}

Expand Down