[CLEANUP] Use accessors in OutputFormatter
#966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid direct access to `OutputFormat` properties as well as variable access and magic methods. Also drop some dead code. We might possibly want to drop the `space` method altogether, but that's out of scope for this change.
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Feb 20, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
It does indeed seem that the $sType parameter is now unused and can be removed.
Whilst making this change, could we not also remove the Hungarian notation from $sSpaceString?
Collaborator
Author
I'd prefer to do that in a separate change. |
JakeQZ
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid direct access to
OutputFormatproperties as well as variable access and magic methods.Also drop some dead code.
We might possibly want to drop the
spacemethod altogether, but that's out of scope for this change.