-
Notifications
You must be signed in to change notification settings - Fork 150
[TASK] Move up getAllDeclarationBlocks to CSSBlockList
#996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Waiting for #991 to be merged first as there will probably be merge conflicts. |
getAllDeclarationBlocks up to CSSBlockListgetAllDeclarationBlocks to CSSBlockList
013250c to
3f7a428
Compare
3f7a428 to
ae0d883
Compare
JakeQZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names of the moved test methods don't match those finally agreed upon in #991.
OK. But the |
Oh, that shouldn't have happened. Hold on … |
Move this method up without any changes to the method or its callers. We'll clean this up in later changes. Part of #994.
ae0d883 to
5fcbbed
Compare
Fixed now. Good catch! |
JakeQZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR here is about
getAllDeclarationBlocks. #991 is aboutgetAllRuleSets.
I originally thought that the tests had been renamed from #991, since I was looking at the removed getAllRuleSets tests and failed to spot that the moved tests were those for getAllDeclarationBlocks.
I've checked more thoroughly now and confirm that the only difference in the moved tests is the subject now being a ConcreteCSSBlockList rather than a Document.
Move this method up without any changes to the method or its callers.
We'll clean this up in later changes.
Part of #994.