Added newsfeed for the state of Hessen (Germany)

[thorstenMueller]

As requested in issue #48 i've added a german newsfeed (radiostation) for the state of Hessen.

[krisgesling]

Hey Thorsten,

With recent updates I've realised that we need to change the way we handle settings changes in the backend. Currently anytime a small change like this is made to a Skill, the backend treats it as a completely different block of settings. This means that it effectively wipes the settings for all existing users.

So I'm not keen to merge any more settings changes until we find a better way to handle this scenario. Unfortunately without the settings change, you would need to request the station by name each time.

A different way to get around this might be to update the default_stations function to provide more granular defaults? Eg anyone else in Hessen should get this by default rather than a more generic national station.

[thorstenMueller]

Hey Kris.

This means that it effectively wipes the settings for all existing users.

Oh, didn't know about that.
Due i've currently no idea on how you could optimize your backend i wish you best of luck for finding a more suitable solution.

[thorstenMueller]

Hey @krisgesling .
I've updated the PR based on your chat session.

What do you think?

[krisgesling]

Yeah, I think we can still include it without the settings change for the moment.

Thanks for cleaning up the intent_handler decorator too. We haven't really pushed the deprecation of it but the longer version is no longer needed and I think it will be less confusing for new devs if we just have the one.

[krisgesling]

Maybe the key could be shortened to HRI?
From memory this is only really used to match the Skill setting to the station. The voice commands are based on the first element of the tuple which would remain 'hr-info'

If there's other longer names that people might use to reference the station you can also add this into dialog/lang/alt.feed.name.value

[thorstenMueller]

I've updated PR based on your suggestions.

[krisgesling]

Looks good.

"hr info" is a little hard to trigger as a station name but is the alias working well when you ask for the station by name?

[thorstenMueller]

Hey @krisgesling
Sorry for the late response. I'll check this within the next days and give you feedback.