Add marquee text type and fix metadata for UI#53
Open
AIIX wants to merge 2 commits intoMycroftAI:21.02from
Open
Add marquee text type and fix metadata for UI#53AIIX wants to merge 2 commits intoMycroftAI:21.02from
AIIX wants to merge 2 commits intoMycroftAI:21.02from
Conversation
6 tasks
krisgesling
reviewed
Feb 23, 2022
| console.log("Image: " + root.thumbnail) | ||
| // If CPS Title or Author is missing try fetch it from qmultimedia metainfo | ||
| if (!root.title && root.playerMeta) { | ||
| console.log("Should not be here") |
Contributor
There was a problem hiding this comment.
Little nitpick - can we try to be more descriptive with these?
Maybe something like the comment above, then we may not need the comment at all eg:
"CPS metadata is missing the track title. Fetching qmultimedia metainfo"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of PR
If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so:
- [x]CLA