fix: Set PageMerge to default to get merged content for plain SVGs#826
Merged
Myriad-Dreamin merged 2 commits intoMyriad-Dreamin:mainfrom Jan 24, 2026
Merged
fix: Set PageMerge to default to get merged content for plain SVGs#826Myriad-Dreamin merged 2 commits intoMyriad-Dreamin:mainfrom
Myriad-Dreamin merged 2 commits intoMyriad-Dreamin:mainfrom
Conversation
Contributor
Author
|
Hi @Myriad-Dreamin, I know you're busy with other projects. This is just a gentle reminder that the CI is still awaiting your approval. Since GitHub doesn't always notify for new commits, I thought I'd reach out directly. |
Owner
|
@TeddyHuang-00 There are many backloged PRs in tinymist and I'm processing them. This PR looks good to me, and I will merge it quickly, but I may not make a typst.ts release in recent future :(. |
Contributor
Author
Totally understandable. Thank you for your awesome work, BTW.
No worries. Since most people can just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824
Explanation: The plain SVG target expected merged pages, while this is only true when the
mergeoption is set inExportSvgTask, so the simplest fix to this is to add a defaultPageMergeto the options.This can be verified by adding the following test to
simple-test.js:which, now with the fix, will pass.
P.S., it might be a good idea to expose this option to the node API, but that's a different topic and requires consideration. The current fix just get the failing compilation to work.