fix(vite-plugin): always resolve typst imports to absolute paths#835
Open
pynappo wants to merge 2 commits intoMyriad-Dreamin:mainfrom
Open
fix(vite-plugin): always resolve typst imports to absolute paths#835pynappo wants to merge 2 commits intoMyriad-Dreamin:mainfrom
pynappo wants to merge 2 commits intoMyriad-Dreamin:mainfrom
Conversation
Owner
|
I don't know if we will solve the issue but these changes generally look good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is the correct fix but it does work for me, i just came up with the fix after debugging for a while and looked at various vite plugins to see if they do similar things.
Motivation: I'm setting up a SvelteKit blog and I want to write articles in typst then compile to HTML.
Expected:
When i have this /blog/article/[[slug]]/page.server.ts, navigating to
/blog/article/initshould be able to properly import blog/article/init.typ.Actual:
Somehow, this works with vite dev but not vite build. It looks like when I use a relative path to a typst file, the vite plugin does not resolve the relative id, so the compiler assumes the path is relative to the root of the project at build time.
In dev, it seems like vite automatically resolves the id to an absolute path before the vite plugin gets it.
I originally figured out this behavior by switching the vite plugin to use
typst-cliand then printing out the command that vite-plugin-typst uses. I don't have the exact logs atm but it was basically:With vite dev:
With vite build: