[5/n][vm-rewrite][sui][roughcut] Update sui deps on Move, add new trait implementations, and add some small helpers#21069
Closed
tzakian wants to merge 1 commit intotzakian/vm-rewrite-adapter-4from
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
f255e3f to
486cb40
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-5
branch
from
2f24850 to
49f2c90
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
486cb40 to
4dc2972
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-5
branch
from
49f2c90 to
b5ffa61
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
4dc2972 to
87b1ca9
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-5
branch
from
b5ffa61 to
fb777e6
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
87b1ca9 to
687bf1d
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-5
branch
from
fb777e6 to
a02ac4b
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…trait implementations. Things are still a bit rough around the edges in terms of getting the execution versioning story right around deps into the VM-runtime (e.g., for `Serializable` value, cost tables etc). But that will be done in a later PR. In particular, here the direct dependency on `move-execution/crates/shared` in sui-types will be removed once we pull the shared legacy code crate out of `move-execution` and into something like `legacy_vm_types` or similar under `move/crates`. NB: The code in the PR may not be working as future PRs will build on top of this.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
687bf1d to
60be049
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-5
branch
from
a02ac4b to
2f9e925
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things are still a bit rough around the edges in terms of getting the execution versioning story right around deps into the VM-runtime (e.g., for
Serializablevalue, cost tables etc). But that will be done in a later PR.In particular, here the direct dependency on
move-execution/crates/sharedin sui-types will be removed once we pull the shared legacy code crate out ofmove-executionand into something likelegacy_vm_typesor similar undermove/crates.NB: The code in the PR may not be working as future PRs will build on top of this.