[14/n][vm-rewrite] Fix up sui-side tests#21178
Closed
tzakian wants to merge 1 commit intotzakian/vm-rewrite-adapter-12from
Closed
[14/n][vm-rewrite] Fix up sui-side tests#21178tzakian wants to merge 1 commit intotzakian/vm-rewrite-adapter-12from
tzakian wants to merge 1 commit intotzakian/vm-rewrite-adapter-12from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-13
branch
from
fc9315b to
b3f93fe
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-13
branch
from
b3f93fe to
fdccafb
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-13
branch
from
fdccafb to
e3db6f8
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Fix a number of different things in order to get Sui-side tests passing:
* Handle including the system packages for all linkages outside of
system transactions (was missing this for publish and upgrade commands
where this is needed for the resolution of the upgrade cap and the
like).
* Handle typetags, and converting them to be runtime type tags before
flowing them into the VM (always). NB: still some work here in the
object runtime.
* Handle duplicate modules in packages. This is now an error when
constructing a `MovePackage` and previously it was an error in the VM.
However duplicate modules in package are no longer expressible in the
VM's public interface, so moving this into the Move package seemed
like the right place.
- Note for the future: This change may need to be protocol versioned
as it's a change outside of sui types, however I don't think we need
to version it since we will check this in the old VM before creating
the package, and therefore would never hit the new error with it.
* Change in graphql test is just a change in the order of the headers
and not a meaningful change.
* Ignored one test that is failing for an unrelated reason as far as I
can tell, once we do another rebase I'll re-enable and dig in to see
if there's still a problem with it.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-12
branch
from
8704f63 to
9846ab1
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-13
branch
from
e3db6f8 to
6b85efd
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
requested review from
amnn,
emmazzz,
stefan-mysten and
wlmyng
as code owners
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
changed the title
Contributor
Author
|
merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for Sui-side tests using the new VM. Nothing major has changed however -- we now check for duplicate modules in a package when creating a
MovePackageand return an error is so. This is the main change. This is currently not protocol gated -- and I don't believe it needs to be based on the existing publishing flow in old adapter (but we'll double check this and gate it if need be once we start moving this intomain, but for now it's fine).