[indexer-alt-framework] flakey test fix #24491
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unlucky enough to not be able to process the first 11 checkpoints before saturation, we'll stall forever
wlmyng
requested review from
amnn,
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras and
tpham-mysten
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
force-pushed
the
indexer-alt-framework-flakey-tasked-pipeline-test
branch
from
5839699 to
d0a0aec
Compare
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…xed the flakiness.. why is that?
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…ther decrease the duration of this test.
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…work and speed up this test
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 3, 2025
Contributor
amnn
left a comment
amnn
left a comment
There was a problem hiding this comment.
Accepting to unblock the flaky test fix, but looking at the rest of the test, I still see
// Lenient check that not all checkpoints < 250 were committedI thought in the review we discussed not doing this because it would because it could fail with low probability and that instead we should control execution such that you can know precisely how many checkpoints are skipped?
Contributor
Author
That was indeed done. I'll remove the comment. |
wlmyng
deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the default ingestion concurrency of 200 means that if the indexer is unlucky enough to not be able to process the first 11 checkpoints before saturation, we'll stall forever
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.