[sui-pkg-alt] move-analyzer fixes #24493
Open
+64
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
stefan-mysten
commented
Dec 2, 2025
Comment on lines
-364
to
-366
| // TODO: we need to rework on loading the root pkg only once. | ||
| let dependencies = root_pkg.packages(); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
moved it up a bit
stefan-mysten
commented
Dec 2, 2025
Comment on lines
117
to
+126
| let clean = strip_comments(contents); | ||
| let mut set = HashSet::new(); | ||
|
|
||
| // This matches `module a::b {}`, and `module a::b;` cases. | ||
| // In both cases, the match is the 2nd group (so `match.get(1)`) | ||
| let regex = Regex::new(MODULE_REGEX).unwrap(); | ||
|
|
||
| for cap in regex.captures_iter(&clean) { | ||
| set.insert(cap[1].to_string()); | ||
| } | ||
|
|
||
| Ok(set | ||
| .into_iter() | ||
| .filter(|name| !is_address_like(name.as_str())) | ||
| Ok(MODULE_REGEX_COMPILED | ||
| .captures_iter(&clean) | ||
| .filter_map(|cap| { | ||
| let name = &cap[1]; | ||
| (!is_address_like(name)).then(|| name.to_string()) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
I think this should be slightly more optimized, particularly that we're reusing the REGEX rather than creating a new one every time.
…x rather than creating a new one every time
stefan-mysten
force-pushed
the
sui-pkg-alt-move-analyzer-fixes
branch
from
b9a3348 to
207730e
Compare
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings a few fixes to move-analyzer and a small optimization to reuse a regex rather than creating a new one every time.
Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.