Skip to content

fix(indexer-framework): clap requires group name #24501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(indexer-framework): clap requires group name #24501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/sui-indexer-alt-framework/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ pub struct TaskArgs {
///
/// The framework ensures that tasked pipelines never commit checkpoints below the main
/// pipeline’s pruner watermark. Requires `--reader-interval-ms`.
#[arg(long, requires = "reader-interval-ms")]
#[arg(long, requires = "reader_interval_ms")]
Copy link
Collaborator

@evan-wall-mysten evan-wall-mysten Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need unit tests or at least one that tests the proper usage?

TaskArgs::parse_from(vec!["cmd", "--task", "t", "--reader-interval-ms", "0"]);

Copy link
Contributor Author

@amnn amnn Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not a bad idea -- will try it!

task: Option<String>,

/// The interval in milliseconds at which each of the pipelines on a tasked indexer should
Expand Down
Loading