[bella-ciao] Remove TypeView
#25129
[bella-ciao] Remove TypeView
#25129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
left a comment
cgswords
left a comment
There was a problem hiding this comment.
LGTM, but: are we ever going to regret removing this information from the gas?
| ) -> PartialVMResult<()> { | ||
| self.charge_instr_with_size( | ||
| Opcodes::CALL_GENERIC, | ||
| ((ty_args.len() + args.len() + 1) as u64).into(), |
There was a problem hiding this comment.
Do we care about this cost change?
There was a problem hiding this comment.
Not really -- this is only used by the Move CLI outside of the Sui CLI.
I honestly think we should consider removing this entirely and just using the tiered_gas_schedule as that tracks most closely to the metering we do on the Sui side.
cgswords
left a comment
cgswords
left a comment
There was a problem hiding this comment.
LGTM, assuming we did not want this info anyway. @dariorussi might have opinions, too.
LGTM too, we can chat more but it seems reasonable? |
Description
Removes
TypeViewand its usages.The gas changes are because of the gas charger changes in
dev_utilsgas schedule. Note that there are no semantic changes to the real gas meter on the Sui side though.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.