[jsonrpc] Change cursor type from ObjectID to String for ObjectsPage used in owned objects queries.#25134
Closed
stefan-mysten wants to merge 3 commits intoMystenLabs:mainfrom
Closed
Conversation
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
stefan-mysten
changed the title
stefan-mysten
commented
Jan 28, 2026
| @@ -3629,7 +3629,7 @@ async fn test_get_owned_objects_owned_by_address_and_check_pagination() -> Resul | |||
| .with_previous_transaction(), | |||
| ), | |||
| )), | |||
| cursor, | |||
| cursor.clone(), | |||
Contributor
Author
There was a problem hiding this comment.
ObjectID has Copy, so the cursor now needs to be cloned as String does not have Copy.
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
reviewed
Feb 4, 2026
| @@ -164,6 +165,16 @@ impl<R: ReadApiServer> IndexerApiServer for IndexerApi<R> { | |||
| self.metrics.get_owned_objects_limit.observe(limit as f64); | |||
| let SuiObjectResponseQuery { filter, options } = query.unwrap_or_default(); | |||
| let options = options.unwrap_or_default(); | |||
| let cursor = match cursor { | |||
Contributor
There was a problem hiding this comment.
Same comment as on the other PR -- it should still be a stringified ObjectID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the JSON RPC to use a String for cursor type instead of an ObjectID.
Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
suix_getOwnedObjects) has changed fromObjectIDtoString. In practice, if cursors are passed to the query requests as they're received, the client should see no difference and would not require any changes.