Make test_simulated_load_rolling_restarts_all_validators faster / more reliable #25182
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mystenmark
commented
Jan 30, 2026
mystenmark
commented
- Use shorter request timeout in test configurations: This lessens the chance of having a payload exhaust its retry budget before completing
- Speed up rolling restart test: the length of the test earlier wasn't doing much, since the real test is whether we can reconfigure, which only happens at the end
Reduce the default request timeout from 30s to 10s when running in test configurations (msim, debug_assertions, antithesis). This allows more retries during validator rolling restarts and epoch changes, fixing flaky test failures in test_simulated_load_rolling_restarts_all_validators. The shorter timeout is applied via a LazyLock that checks in_test_configuration() at runtime, ensuring production behavior remains unchanged. Co-Authored-By: Claude Opus 4.5 <[email protected]>
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.