[consensus] disable periodic sync only when commit sync is not progressing #25188
+53
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mwtian
force-pushed
the
tmw/periodic-sync
branch
from
f6a17f3 to
1d4632c
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mwtian
force-pushed
the
tmw/periodic-sync
branch
from
1d4632c to
5417741
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
approved these changes
Jan 30, 2026
Contributor
akichidis
left a comment
akichidis
left a comment
There was a problem hiding this comment.
I am approving but I would suggest giving this a good test before rollout.
Comment on lines
+919
to
+920
| // However, if local commit index has not progressed for too long, we run periodic sync anyway to help unblock progress, in case large commit sync | ||
| // requests are failing too frequently. |
Contributor
There was a problem hiding this comment.
Have we actually observed this in any of our environments? Because I would expect this to not significantly help and maybe even create some race between the synchronizer and commit syncer
Contributor
Author
There was a problem hiding this comment.
Yes I have observed this in tests where sometimes commit sync took a long time. Let me optimize and test it out a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use periodic sync as the fallback when commit sync is not progressing for various reasons.
Test plan
CI